fix: improve object simulator. #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1k0
changed the title
n1k0
force-pushed
the
chore/polish-object-bookmarks
branch
from
59b7cea
to
eb26239
Compare
n1k0
force-pushed
the
chore/polish-object-bookmarks
branch
from
960ac8e
to
6c901a0
Compare
n1k0
force-pushed
the
chore/polish-object-bookmarks
branch
from
b49b6ef
to
03ee786
Compare
n1k0
force-pushed
the
chore/polish-object-bookmarks
branch
from
03ee786
to
a6dcfd4
Compare
n1k0
force-pushed
the
chore/polish-object-bookmarks
branch
from
4f2ff8b
to
c307b8c
Compare
n1k0
force-pushed
the
chore/polish-object-bookmarks
branch
from
6bd5015
to
2c50378
Compare
|
@vjousse this is now ready for review. |
vjousse
approved these changes
Oct 14, 2024
@vjousse because we only have two processes available and having two distinct amounts of the same plastic would look weird I think… but that's probably some feedback we should get from POs. |
|
Shouldn't we display the density too to help understand the computation? |
|
I think it should be rendered in the explorer but here... I don't know, that would also clutter the ui. Let's wait for user feedback here. |
n1k0
force-pushed
the
chore/polish-object-bookmarks
branch
from
dd212b3
to
4b0ed3c
Compare
vjousse
pushed a commit
that referenced
this pull request
Nov 7, 2024
## [2.5.0](https://github.com/MTES-MCT/ecobalyse/compare/v2.4.0..v2.5.0) (2024-11-06) ### 🚀 Features - Add bookmarks for objects ([#781](#781)) - Add object explorer pages. ([#803](#803)) - Distinguish Objects from Veli. ([#813](#813)) - Display score without durability ([#815](#815)) - Textile export ([#808](#808)) - Object export ([#812](#812)) ### 🪲 Bug Fixes - Create object encrypted file for versions ([#800](#800)) - Improve object simulator. ([#799](#799)) - Fix encoded display name field. ([#820](#820)) ### 🚜 Refactor - Aggregate in python ([#794](#794)) - Turn food process category into a list ([#795](#795)) - Aggregate in python ([#807](#807)) ### ⚙️ Miscellaneous Tasks - Upgrade dependencies to their latest version, Oct. 2024. ([#801](#801)) - Add tolerance to tests comparison ([#810](#810)) - *(data)* New export ([#819](#819)) ###◀️ Revert - "refactor: aggregate in python" ([#806](#806)) <!-- generated by git-cliff --> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problems
🍰 Solution
Implement or fix aforementioned tasks.
🏝️ How to test